-
-
Notifications
You must be signed in to change notification settings - Fork 93
Allow global state expressions in layer visibility #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Is this considered a style spec change? |
|
Native doesn't support this yet so as far as Native is concerned changes are not a problem. |
|
There should probably a design proposal issue instead of this PR to discuss this, but as far as I understand this change, it might mean that every feature can change the visibility of a layer? |
Of course not, this is what filters are for. This PR makes |
|
I wrote a design proposal in #1364 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
- Coverage 95.37% 92.59% -2.78%
==========================================
Files 114 113 -1
Lines 7395 4458 -2937
Branches 2326 1394 -932
==========================================
- Hits 7053 4128 -2925
+ Misses 342 330 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
add tests to show that `zoom`, `feature` and `feature-state` are ignored
4f83103 to
9778bc2
Compare
Launch Checklist
Implements #6495
CHANGELOG.mdunder the## mainsection.